Changeset 17105

Timestamp:

2008-08-29T15:19:56+12:00 (16 years ago)

Author:

mdewsnip

Message:

Not sure why "gdbm-txtgz" was made the default, particularly since collections built with this don't work for me. Changing default back to "gdbm".

File:

• gsdl/trunk/perllib/dbutil.pm (modified) (7 diffs)

gsdl/trunk/perllib/dbutil.pm

@@ -38 +38 @@
     return &open_infodb_write_handle_sqlite($infodb_file_path);
     }
-    elsif ($infodb_type eq "gdbm")
-    {
-    return &open_infodb_write_handle_gdbm($infodb_file_path);
-    }
-
-    # Use text (gzipped) version ready for conversion to GDBM 
-    # if the infodb type is empty or not one of the values above
-    return &open_infodb_write_handle_gdbm_txtgz($infodb_file_path);
+    elsif ($infodb_type eq "gdbm-txtgz")
+    {
+    return &open_infodb_write_handle_gdbm_txtgz($infodb_file_path);
+    }
+
+    # Use GDBM if the infodb type is empty or not one of the values above
+    return &open_infodb_write_handle_gdbm($infodb_file_path);
 }
 
@@ -58 +57 @@
     return &close_infodb_write_handle_sqlite($infodb_handle);
     }
-    elsif ($infodb_type eq "gdbm")
-    {
-    return &close_infodb_write_handle_gdbm($infodb_handle);
-    }
-
-    # Use text (gzipped) version ready for conversion to GDBM 
-    # if the infodb type is empty or not one of the values above return
-    &close_infodb_write_handle_gdbm_txtgz($infodb_handle);
+    elsif ($infodb_type eq "gdbm-txtgz")
+    {
+    return &close_infodb_write_handle_gdbm_txtgz($infodb_handle);
+    }
+
+    # Use GDBM if the infodb type is empty or not one of the values above
+    &close_infodb_write_handle_gdbm($infodb_handle);
 }
 
@@ -71 +69 @@
 sub get_default_infodb_type
 {
-    return "gdbm-txtgz";
+    # The default is GDBM so everything works the same for existing collections
+    # To use something else, specify the "infodbtype" in the collection's collect.cfg file
+    return "gdbm";
 }
 
@@ -85 +85 @@
     return &get_infodb_file_path_sqlite($collection_name, $infodb_directory_path);
     }
-    elsif ($infodb_type eq "gdbm")
-    {
-    return &get_infodb_file_path_gdbm($collection_name, $infodb_directory_path);
-    }
-
-    # Use text (gzipped) version ready for conversion to GDBM 
-    # if the infodb type is empty or not one of the values above return
-    return &get_infodb_file_path_gdbm_txtgz($collection_name, $infodb_directory_path);
+    elsif ($infodb_type eq "gdbm-txtgz")
+    {
+    return &get_infodb_file_path_gdbm_txtgz($collection_name, $infodb_directory_path);
+    }
+
+    # Use GDBM if the infodb type is empty or not one of the values above
+    return &get_infodb_file_path_gdbm($collection_name, $infodb_directory_path);
 }
 
@@ -106 +105 @@
     return &read_infodb_file_sqlite($infodb_file_path, $infodb_map);
     }
-    elsif ($infodb_type eq "gdbm")
-    {
-    return &read_infodb_file_gdbm($infodb_file_path, $infodb_map);
-    }
-
-    # Use text (gzipped) version ready for conversion to GDBM 
-    # if the infodb type is empty or not one of the values above return
-    return &read_infodb_file_gdbm_txtgz($infodb_file_path, $infodb_map);
+    elsif ($infodb_type eq "gdbm-txtgz")
+    {
+    return &read_infodb_file_gdbm_txtgz($infodb_file_path, $infodb_map);
+    }
+
+    # Use GDBM if the infodb type is empty or not one of the values above
+    return &read_infodb_file_gdbm($infodb_file_path, $infodb_map);
 }
 
@@ -128 +126 @@
     return &write_infodb_entry_sqlite($infodb_handle, $infodb_key, $infodb_map);
     }
-    elsif ($infodb_type eq "gdbm")
-    {
-    return &write_infodb_entry_gdbm($infodb_handle, $infodb_key, $infodb_map);
-    }
-
-    # Use text (gzipped) version ready for conversion to GDBM 
-    # if the infodb type is empty or not one of the values above return
-    return &write_infodb_entry_gdbm_txtgz($infodb_handle, $infodb_key, $infodb_map);
+    elsif ($infodb_type eq "gdbm-txtgz")
+    {
+    return &write_infodb_entry_gdbm_txtgz($infodb_handle, $infodb_key, $infodb_map);
+    }
+
+    # Use GDBM if the infodb type is empty or not one of the values above
+    return &write_infodb_entry_gdbm($infodb_handle, $infodb_key, $infodb_map);
 }
 
@@ -265 +262 @@
     return $infodb_file_handle;
 }
+
 
 sub close_infodb_write_handle_gdbm