Changeset 27293 for main/trunk/greenstone2/macros/document.dm

Timestamp:

2013-05-02T17:43:31+12:00 (11 years ago)

Author:

ak19

Message:

Some bugfixes and improvements to the existing Add User Comment form before committing changes for the authentication. Fixes like checking for empty strings entered for the comment which shouldn't go in the database. And after a comment is submitted, it needs to be added to the existing list of displayed user comments, instead of reloading them all.

File:

• main/trunk/greenstone2/macros/document.dm (modified) (2 diffs)

main/trunk/greenstone2/macros/document.dm

@@ -166 +166 @@
 
     function addUserComment(_username, _comment, _docid, doc) \{
+
+        // don't add empty strings for name/comment     
+
+        // http://stackoverflow.com/questions/498970/how-do-i-trim-a-string-in-javascript
+        var trimmed_username=_username.replace(/^\s+|\s+$/g, '');
+        var trimmed_comment = _comment.replace(/^\s+|\s+$/g, '');
+        
+        if(!trimmed_username || !trimmed_comment) \{
+              doc.AddUserCommentForm.comment.value = "";
+              doc.AddUserCommentForm.username.value = "";
+              doc.getElementById("usercommentfeedback").innerHTML = "_text-is-empty_";
+              return;
+        \}
+
         // Need to the add user comment meta of username, timestamp and comment to the
         // topmost section of the document. So only get the docId up to any period mark:
@@ -241 +255 @@
 
         // update display of existing user comments to show the newly added comment
-        loadUserComments();
+        var usercommentdiv = document.getElementById("usercomments");
+        if(usercommentdiv != undefined) \{
+             displayInUserCommentList(usercommentdiv, _username, _timestamp, _comment);
+        \}
     \}
 </script>