Changeset 27570

Timestamp:

2013-06-07T10:53:10+12:00 (11 years ago)

Author:

jmt12

Message:

Make the warning about binmode() not being applicable more meaningful, and display it only once

File:

• gs2-extensions/parallel-building/trunk/src/perllib/FileUtils/HDThriftFS/ThriftFH.pm (modified) (3 diffs)

gs2-extensions/parallel-building/trunk/src/perllib/FileUtils/HDThriftFS/ThriftFH.pm

@@ -50 +50 @@
   $self->{'mode'} = 'r';
   $self->{'read_offset'} = 0; # A read offset
+  $self->{'warnings'} = {'binmode' => 0};
   return bless $self, $class;
 }
@@ -241 +242 @@
   return $self;
 }
-## open()
-
-
+## open() ##
+
+
+## @function binmode()
+#
 sub BINMODE
 {
-  print STDERR "ThriftFH::BINMODE() - implement me!\n";
-}
-
+  # Have we warned about BIN mode not being applicable?
+  if ($self->{'warnings'}->{'binmode'} != 1)
+  {
+    print STDERR "Notice! BIN mode not applicable in ThriftFS (all data base91 encoded)\n";
+    # we have now!
+    $self->{'warnings'}->{'binmode'} = 1;
+  }
+}
+## BINMODE
+
+
+## @function eof()
+#
 sub EOF
 {
@@ -254 +267 @@
   return $self->{'eof'};
 }
+## eof() ##
+
 
 sub TELL