Changeset 28655

Timestamp:

2013-11-20T13:01:51+13:00 (10 years ago)

Author:

jmt12

Message:

Added in some extra testing to check that the duration of the converted video is in the same ballpark as the input video - I wanted to detect an occasional issue where a 10 minute video got truncated down to a few seconds

File:

• gs2-extensions/video-and-audio/trunk/src/perllib/plugins/SimpleVideoPlugin.pm (modified) (5 diffs)

gs2-extensions/video-and-audio/trunk/src/perllib/plugins/SimpleVideoPlugin.pm

@@ -230 +230 @@
   print ' - Extracting metadata using MediaInfo...';
   my $mi_metadata = $self->getMetadata($ivideo_path);
+  my $input_video_duration = &parseDurationAsSeconds($mi_metadata->{'General'}->{'Duration'});
+  $doc_obj->add_utf8_metadata($topsection,"Duration",$mi_metadata->{'General'}->{'Duration'});
   $doc_obj->add_utf8_metadata($topsection,"Format", 'multimedia (' . $mi_metadata->{'General'}->{'Format'} . ')');
   if (defined $mi_metadata->{'General'}->{'File_size'})
@@ -239 +241 @@
     $doc_obj->set_metadata_element($topsection, "FileSize", &FileUtils::fileSize($ivideo_path));
   }
-  $doc_obj->add_utf8_metadata($topsection,"Duration",$mi_metadata->{'General'}->{'Duration'});
   if (defined $mi_metadata->{'Video'}->{'Format_Info'} && defined $mi_metadata->{'Video'}->{'Format'})
   {
@@ -318 +319 @@
     die("Fatal Error! Failed to convert video: " . $ovideo_path . "\nReason:" . $! . "\n");
   }
+  # Extra check - ensure the converted video is approximately the same duration
+  # as the input video, given or take around 5 seconds
+  my $output_raw_video_duration = &getDuration($ovideo_path);
+  my $output_video_duration = &parseDurationAsSeconds($output_raw_video_duration);
+  if (abs($input_video_duration - $output_video_duration) > 5)
+  {
+    print STDERR "!Warning! Output video does not have same duration as input video.\n";
+  }
   print STDERR " - conversion done!\n";
 
@@ -371 +380 @@
 }
 
+
+## @function getDuration()
+#
+sub getDuration
+{
+  my ($video_path) = @_;
+  my $cmd = 'mediainfo --Inform="General;%Duration/String%" "' . $video_path . '" 2>&1';
+  my $duration = `$cmd`;
+  return $duration;
+}
+## getDuration() ##
+
+
+## @function getMetadata()
+#
 sub getMetadata
 {
@@ -400 +424 @@
   return $metadata;
 }
+## getMetadata() ##
+
+
+## @function parseDurationAsSeconds()
+#
+sub parseDurationAsSeconds
+{
+  my ($duration_str) = @_;
+  my $seconds = 0;
+  # h - hours
+  if ($duration_str =~ /(\d+)h/)
+  {
+    $seconds += $1 * 60 * 60;
+  }
+  # mn - minutes
+  if ($duration_str =~ /(\d+)mn/)
+  {
+    $seconds += $1 * 60;
+  }
+  # s - seconds
+  if ($duration_str =~ /(\d+)s/)
+  {
+    $seconds += $1;
+  }
+  # ms - milliseconds (ignore - I'll be lucky to match to the closest second)
+  return $seconds;
+}
+## parseDurationAsSeconds() ##
 
 1;