Changeset 28732 for main

Timestamp:

2013-12-02T18:52:05+13:00 (10 years ago)

Author:

ak19

Message:

Diego found a bug that crashed the server in his collection which set the OIDtype to incremental and used a classifier on dc.Subject meta. When the OIDs generated were too short, such as happens when maxdocs is low or the number of docs in the collection is low, the server crashes. Have now added a test in the dbclass.cpp code that ensures we don't substring the OID's tail if this is too short for the substring operation. This now works with Diego's collection which used to crash for me before.

File:

• main/trunk/greenstone2/common-src/src/lib/dbclass.cpp (modified) (1 diff)

main/trunk/greenstone2/common-src/src/lib/dbclass.cpp

@@ -194 +194 @@
     tailarray.push_back(tail);
     OID.erase (OID.end()-3, OID.end());
-    tail = substr (OID.end()-3, OID.end());
+
+    if(OID.size() <= 3) {
+        break;
+    } else {
+        tail = substr (OID.end()-3, OID.end());
+    }
     if (tail == ".rt") {
       get_top (inOID, OID);