Changeset 28775 for gs2-extensions/tdb-edit/trunk/src/perllib/SocketsSwimmingThreadPoolServer.pm

Timestamp:

2013-12-18T12:16:17+13:00 (10 years ago)

Author:

jmt12

Message:

Apparently trying to join() threads that have been detached() is actually wrong (detach means 'run this, I don't care about result' while join implies 'okay, wait until this is done and then return result'). Since I don't care about result values (they're always 1) I'll just remove the joining code since it doesn't seem to be portable to Medusa anyway

File:

• gs2-extensions/tdb-edit/trunk/src/perllib/SocketsSwimmingThreadPoolServer.pm (modified) (1 diff)

gs2-extensions/tdb-edit/trunk/src/perllib/SocketsSwimmingThreadPoolServer.pm

@@ -162 +162 @@
     $closed_queue->enqueue($n);
   }
+
+  # Shouldn't join() detached threads?
   # Properly rejoin thread
   # Newer versions of module thread
-  if (defined $self->can('is_joinable'))
-  {
-    print "[debug] using newer thread->is_joinable... ";
-    if ($self->is_joinable())
-    {
-      $self->join();
-      print "joined\n";
-    }
-    else
-    {
-      print "not joinable\n";
-    }
-  }
-  else
-  {
-    print "[debug] using newer thread::is_detached... ";
-    my $thread = threads->self();
-    if (!$thread->is_detached())
-    {
-      $thread->join();
-      print "joined\n";
-    }
-    else
-    {
-      print "not detached\n";
-    }
-  }
+  #if (defined $self->can('is_joinable'))
+  #{
+  #  print "[debug] using newer thread->is_joinable... ";
+  #  if ($self->is_joinable())
+  #  {
+  #    $self->join();
+  #    print "joined\n";
+  #  }
+  #  else
+  #  {
+  #    print "not joinable\n";
+  #  }
+  #}
+  #else
+  #{
+  #  print "[debug] using newer thread->is_detached... ";
+  #  my $thread = threads->self();
+  #  if (!$thread->is_detached())
+  #  {
+  #    $thread->join();
+  #    print "joined\n";
+  #  }
+  #  else
+  #  {
+  #    print "not detached\n";
+  #  }
+  #}
 }