Changeset 29674 for main/trunk/package-kits/scripts/gs-servlet.pl

Timestamp:

2015-01-09T11:57:42+13:00 (9 years ago)

Author:

Jeremy Symon

Message:

Should use 'exists', not 'defined' when checking if an element exists in a hash

File:

• main/trunk/package-kits/scripts/gs-servlet.pl (modified) (6 diffs)

main/trunk/package-kits/scripts/gs-servlet.pl

@@ -53 +53 @@
             # Append the new data to the current data
             for my $key (keys %$new) {
-                if ($key eq '.attr' and defined $hash->{'.attr'}) {
+                if ($key eq '.attr' and exists $hash->{'.attr'}) {
                     for my $attr ($new->{'.attr'}) {
                         $hash->{'.attr'}->{$attr} = $new->{'.attr'}->{$attr};
                     }
-                } elsif (defined $hash->{$key}) {
+                } elsif (exists $hash->{$key}) {
                     if (ref $hash->{$key} ne 'ARRAY') {
                         $hash->{$key} = [ $hash->{$key} ];
@@ -94 +94 @@
         sub {
             my $count = 0;
-            if (defined $hash->{servlet}) {
+            if (exists $hash->{servlet}) {
                 $count = 1;
                 my $servlets = $hash->{servlet};
@@ -107 +107 @@
         'Lists the servlets in the current internal state',
         sub {
-            if (defined $hash->{servlet}) {
+            if (exists $hash->{servlet}) {
                 my $servlets = $hash->{servlet};
                 if (ref $servlets eq 'ARRAY') {
@@ -125 +125 @@
         sub {
             my $name = shift @ARGV;
-            if (defined $hash->{servlet}) {
+            if (exists $hash->{servlet}) {
                 my $servlets = $hash->{servlet};
                 if (ref $servlets eq 'ARRAY') {
@@ -156 +156 @@
                 };
             }
-            if (defined $hash->{servlet}) {
+            if (exists $hash->{servlet}) {
                 unless (ref $hash->{servlet} eq 'ARRAY') {
                     $hash->{servlet} = [ $hash->{servlet} ];
@@ -180 +180 @@
         $argc --;
     } elsif ($varargs) {
-    } elsif (defined $commands{$cmd}) {
+    } elsif (exists $commands{$cmd}) {
         # get the argument count of a valid command
         $argc = @{$commands{$cmd}}[2];