Changeset 30616 for main/trunk

Timestamp:

2016-07-22T15:16:54+12:00 (8 years ago)

Author:

ak19

Message:

Useful debug statement when we get an InvocationTargetException (Reflection related issue). The method may be called and may encounter an exception there, yet we still see the InvocationTargetException.

Location:

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service

Files:

• GS2Construct.java (modified) (1 diff)
• ServiceRack.java (modified) (2 diffs)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/GS2Construct.java

@@ -973 +973 @@
         }
         
-        // Open database for reading
+        // Open database for reading. It may not exist if collection is pre-built without archives (such as demo collections)
         String coll_db_file = GSFile.archivesDatabaseFile(this.site_home, collection, dbtype);
         if (!coll_db.openDatabase(coll_db_file, SimpleCollectionDatabase.READ))
         {
-            logger.error("Could not open collection archives database. Somebody already using this database!");
-        }
+            logger.error("Could not open collection archives database. Database doesn't exist or else somebody is already using it?");
+            return;
+        }
+        // now we know we have an archives folder
         String old_value = coll_db.getValue(oid);
         String new_value = old_value.replace("<index-status>B", "<index-status>" + mark);

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/ServiceRack.java

@@ -36 +36 @@
 import org.w3c.dom.Node;
 import org.w3c.dom.NodeList;
+
+import java.io.StringWriter;
+import java.io.PrintWriter;
 
 /**
@@ -294 +297 @@
                         {
                             logger.error("Trying to call a processService type method (process" + to + ") on a subclass(" + this.getClass().getName() + "), but an exception happened:" + e.toString(), e);
-
-                            error_string.append("Trying to call a processService type method (process" + to + ") on a subclass(" + this.getClass().getName() + "), but an exception happened:" + e.toString());
+                            // for debugging, it's useful to see what's really causing this supposed "invocationTargetException"
+                            // When the error message is displayed in the "Net" tab in the browser's web inspector, scroll down to "Caused by"
+                            StringWriter errors = new StringWriter();
+                            e.printStackTrace(new PrintWriter(errors));
+                            String errStr = errors.toString();
+                            errStr += XMLConverter.getString(request);
+
+
+                            error_string.append("Trying to call a processService type method (process" + to + ") on a subclass(" + this.getClass().getName() + "), but an exception happened:" + e.toString() + "\n" + errStr );
                         }
                     }