Changeset 31572 for main/trunk

Timestamp:

2017-04-05T20:13:40+12:00 (7 years ago)

Author:

ak19

Message:

Minor changes ahead of more major ones. Explicitly marking ConstructionEvent members immutable by declaring them final, to make them thread safe (to make them safe to share across multiple threads).

Location:

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build

Files:

• CollectionConstructor.java (modified) (2 diffs)
• ConstructionEvent.java (modified) (1 diff)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/CollectionConstructor.java

@@ -28 +28 @@
     /** Stores the name of the manifest file (if one is needed) */
     protected String manifest_file = null;
-    /** The URL params constructed as a query string, representing the CGI QUERY_STRING to */
+    /** The URL params constructed as a query string, representing the CGI QUERY_STRING to the process */
     protected String query_string = null;
 
@@ -45 +45 @@
     }
 
+    // this method never gets called. And, the way subclass GS2PerlConstructor.runPerlCommand() was originally
+    // coded, setting cancel to true never had any effect anyway in stopping any perl command that was run.
     public void stopAction()
     {

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/ConstructionEvent.java

@@ -10 +10 @@
     private static final int EVENT_ID = RESERVED_ID_MAX+77;
     /** The status associated with the event. */
-    private int status = -1;
+    private final int status;
     /** Any message associated with this event. */
-    private String message = null;
+    private final String message;
     /* Constructor.
      * @param source The <strong>CollectionConstructor</strong> that fired this message.