Changeset 31636 for main/trunk/gli/src/org/greenstone/gatherer/greenstone/Classifiers.java

Timestamp:

2017-04-21T21:09:08+12:00 (7 years ago)

Author:

ak19

Message:

First phase of shifting gli code to use SafeProcess instead of Java Process. This phase takes care of all the easy cases.

File:

• main/trunk/gli/src/org/greenstone/gatherer/greenstone/Classifiers.java (modified) (3 diffs)

main/trunk/gli/src/org/greenstone/gatherer/greenstone/Classifiers.java

@@ -37 +37 @@
 import org.greenstone.gatherer.cdm.Classifier;
 import org.greenstone.gatherer.remote.RemoteGreenstoneServer;
+import org.greenstone.gatherer.util.SafeProcess;
 import org.greenstone.gatherer.util.StaticStrings;
 import org.greenstone.gatherer.util.Utility;
@@ -150 +151 @@
         args.add(classifier.getName());
 
-        // Run the classinfo.pl process
-        Runtime runtime = Runtime.getRuntime();
-        Process process = runtime.exec((String[]) args.toArray(new String[] { }));
-        InputStream input_stream = process.getErrorStream();
-        StringBuffer classinfo_xml_buffer = XMLTools.readXMLStream(input_stream);
-        if (classinfo_xml_buffer != null) {
-            classinfo_xml = classinfo_xml_buffer.toString();
-        }
+
+        // Run the classinfo.pl process:
+        // Create the process.
+        SafeProcess process = new SafeProcess((String[]) args.toArray(new String[] { }));
+
+        // run the SafeProcess
+        int exitVal = process.runProcess();
+        if(exitVal != 0) {
+            throw new Exception("*** Error running classify.pl loadClassifierInfo, process exited with: "
+                    + exitVal);
+        }
+        // get the result: We expect XML to have come out of the process std error stream.
+        classinfo_xml = process.getStdError();
+        ///System.err.println("*********\nClassifierInfo, got:\n" + classinfo_xml + "\n**********\n");
         }
 
@@ -208 +215 @@
         args.add("-xml");
 
-        // Run the classinfo.pl process
-        Runtime runtime = Runtime.getRuntime();
-        Process process = runtime.exec((String[]) args.toArray(new String[] { }));
-        InputStream input_stream = process.getErrorStream();
-        xml = XMLTools.readXMLStream(input_stream);
+        // Run the classinfo.pl process:
+        // Create the process.
+        SafeProcess process = new SafeProcess((String[]) args.toArray(new String[] { }));
+
+        // run the SafeProcess
+        int exitVal = process.runProcess();
+        if(exitVal != 0) {
+            throw new Exception("*** Error running classify.pl loadClassifiersList, process exited with: "
+                    + exitVal);
+        }
+        // get the result: We expect XML to have come out of the process std error stream.
+        xml = new StringBuffer(process.getStdError());
+        ///System.err.println("*********\nClassifierList, got:\n" + xml + "\n**********\n");
         }