Changeset 31671 for main

Timestamp:

2017-05-10T18:37:06+12:00 (7 years ago)

Author:

ak19

Message:

Additional comment

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/CollectionConstructor.java (modified) (1 diff)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/build/CollectionConstructor.java

@@ -99 +99 @@
     }
 
+    // We never call removeListener. If we do start calling removeListener() change the listeners list
+    // over to type ConcurrentLinkedQueue, for reasons explained at
+    // http://stackoverflow.com/questions/8259479/should-i-synchronize-listener-notifications-or-not
+    // The current listeners list type is CopyOnWriteArrayList, which provides thread safety. But it
+    // can still send off events to listeners just as they're being unregistered, and that could be a
+    // problem if we were specifically removing the listener because we wanted to cease it from
+    // listening and responding to subsequent events.
     public boolean removeListener(ConstructionListener listener)
     {