Changeset 31738

Timestamp:

2017-06-14T22:19:39+12:00 (6 years ago)

Author:

ak19

Message:

Don't know how to stop the flashing DOS windows on GS2 when JDBM is used, since I don't know how to replace the popen calls in jdbmnaiveclass.cpp that get the process' output with variants that don't cause flashing DOS prompts. But replacing 2 occurrences of system() calls in jdbmnaiveclass.cpp with gsdltools.cpp's gsdl_system() calls, which hide any DOS prompts on windows. Compiles okay on Windows, and nothing appears to have broken. Doesn't resolve the other instances making calls to JDBM and which use popen calls instead of system().

File:

• main/trunk/greenstone2/common-src/src/lib/jdbmnaiveclass.cpp (modified) (3 diffs)

main/trunk/greenstone2/common-src/src/lib/jdbmnaiveclass.cpp

@@ -137 +137 @@
   delete [] openfile_cstr;
 
-  int status = system(cmd);
+  //int status = system(cmd); // avoid flashing windows
+  int status = gsdl_system(cmd, true, *logout); // true for synchronous call: wait for process to end
   if (status != 0 ) {
     (*logout) << "jdbmnaiveclass: failed to run cmd: " << cmd << endl;
@@ -296 +297 @@
   delete [] openfile_cstr;
 
-  int status = system(cmd);
+  //int status = system(cmd); // causes flashing DOS prompt windows
+  // https://stackoverflow.com/questions/1597289/hide-console-in-c-system-function-win
+  int status = gsdl_system(cmd, true, *logout); // passing false makes it a synchronous call
   if (status != 0) {
     (*logout) << "jdbmnaiveclass: failed to run cmd:" 
@@ -308 +311 @@
 }
 
+
+