Changeset 31741

Timestamp:

2017-06-15T15:47:11+12:00 (6 years ago)

Author:

ak19

Message:

There was a bug when using lucene in GS2 that wasn't present in GS2.86 but in caveats for upcoming 2.87: n-1 documents would appear in the search results, the first was always missing. After investigating, I found the change in behaviour was located between commit revisions 30158 and 30159 in common-src/indexers (lucene-gs Java code) where indexing changed between 0 and 1. Kathy has now fixed the bug in runtime-src colserver, since her changes to lucene-gs may be necessary for GS3 where lucene searching has been working fine with her changes. Tested her fix on Linux with a local update and it seems to work, will retest with a clean install after commit.

File:

• main/trunk/greenstone2/runtime-src/src/colservr/lucenesearch.cpp (modified) (1 diff)

main/trunk/greenstone2/runtime-src/src/colservr/lucenesearch.cpp

@@ -147 +147 @@
   if (queryparams.startresults && queryparams.endresults)
     {
-      cmd += (text_t)" -startresults " + queryparams.startresults;
-      cmd += (text_t)" -endresults " + queryparams.endresults;
+      cmd += (text_t)" -startresults " + (queryparams.startresults - 1);
+      cmd += (text_t)" -endresults " + (queryparams.endresults - 1);
     }