Changeset 32005 for main/trunk

Timestamp:

2017-09-28T18:58:45+13:00 (7 years ago)

Author:

ak19

Message:

Different (and simpler) fix for GS2 imagemagick env clash on sourcing GS2 setup vs running wget after sourcing setup. For GS2 binaries, we never had an imagemagick living in the ext folder, as we got one of our precompiled imagemagick binaries and only unpacked it in ext before moving it into the GS2/bin/OS folder. And now when compiling up GS2 with makegs2.sh, we have the new option of passing in imagemagick as an argument and it also grab the appropriate imagemagick binary and put it into GS2/bin/OS. In either case, there's no imagemagick in the ext folder, which may be for GS3 and/or when imagemagick is compiled up from scratch in a GS checkout.

File:

• main/trunk/greenstone2/makegs2.sh (modified) (2 diffs)

main/trunk/greenstone2/makegs2.sh

@@ -6 +6 @@
 # If you pass in imagemagick, it will grab the appropriate linux/darwin binary, untar
 # this and put its OS subfolder renamed as imagemagick into the bin/os folder.
+
+# Note, Mac (darwin) machines don't always display all env vars on doing env/printenv, 
+# e.g. DYLD_LIBRARY_PATH and DYLD_FALLBACK_LIBRARY_PATH are hidden
+# To display hidden vars follow:
+# http://www.commandlinefu.com/commands/view/6899/print-all-environment-variables-including-hidden-ones
+# but remove capital T from command, making: for _a in {A..Z} {a..z};do _z=\${!${_a}*};for _i in `eval echo "${_z}"`;do echo -e "$_i: ${!_i}";done;done|cat -Tsv
+# into: for _a in {A..Z} {a..z};do _z=\${!${_a}*};for _i in `eval echo "${_z}"`;do echo -e "$_i: ${!_i}";done;done|cat -sv
+# Can redirect the output of the command into files and do a diff to see difference in environment.
 
 getgnomelib=
@@ -117 +125 @@
        popd
    fi
+
+   # the setup script in the ext/imagemagick folder clashes with wget because it sets DYLD(_FALLBACK)_LIBRARY_PATH
+   # on sourcing GS2's setup.bash. Since we're not using the imagemagick in the ext folder for GS2, as the 
+   # precompiled imagemagick binary is moved into GS2/bin/OS, in a GS2 bin release and now here too (in a compiled GS2),
+   # we can remove ext/imagemagick. The env vars it sets refer to the ext/imagemagick folder anyway, which we don't use
+   # for our GS2 binaries, or for GS2 compiled versions using the precompiled imagemagick binary, as imagemagick will
+   # live in GS2/bin/OS in such cases..
+   rm -rf ext/imagemagick
    
 fi