Changeset 32096 for main/trunk/greenstone2/perllib/util.pm

Timestamp:

2017-12-12T16:47:34+13:00 (6 years ago)

Author:

ak19

Message:

Marking all the uses of sysread() with a comment saying they're a candidate to use FileUtils::readUTF8File() in future, if thinking about each case beforehand has confirmed that the contents will indeed be UTF8.

File:

• main/trunk/greenstone2/perllib/util.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/util.pm

@@ -1280 +1280 @@
         # check llssite.cfg for line with url property
         # for server.exe also need to use portnumber and enterlib properties            
-        
+        # The following file reading section is a candidate to use FileUtils::readUTF8File()
+        # in place of calling sysread() directly. But only if we can reason we'd be working with UTF8
         # Read in the entire contents of the file in one hit
         if (!open (FIN, $llssite_cfg)) {