Changeset 32285 for main

Timestamp:

2018-07-18T19:12:33+12:00 (6 years ago)

Author:

ak19

Message:

Fix to sectionalising xpdftools' produced paged_pretty_html: Dr Bainbridge explained that when the total num of pages < 10, we still wanted individual page headings, so GS' section-level search behaviour would work for all PDF docs processed with the sectionalised paged_pretty_html mode.

File:

• main/trunk/greenstone2/perllib/plugins/PDFv2Plugin.pm (modified) (2 diffs)

main/trunk/greenstone2/perllib/plugins/PDFv2Plugin.pm

@@ -570 +570 @@
     my $inner_div_str = $new_dom->to_string;
     my $page_div = "<div id=\"page".$page_num."\">\n";
-    
-    if($self->{'convert_to'} =~ /paged_pretty_html/) { # then add the <h>tags for sectionalising
+
+    # If paged_pretty_html, then add <h>tags for sectionalising
+    if($self->{'convert_to'} =~ /paged_pretty_html/) {
     
     # Append a page range bucket heading if applicable: if we have more than 10 pages
@@ -587 +588 @@
     }
 
-    # No sectionalising for 10 pages or under. Otherwise, every page is a section too, not just buckets
+    # Every page is now a section too, not just buckets.
+    # Whether we're starting a new bucket or not, add a simpler heading: just the pagenumber, "Page #"
+    # However, this should be <H3> when there are buckets and <H2> when there aren't any.
     if($num_html_pages > 10) {
-        # Whether we're starting a new bucket or not, add a simpler heading: just the pagenumber, "Page #"  
-        $page_div .= "<h3 style=\"font-size:1em;font-weight:normal;\">Page ".$page_num."</h3>\n";       
+        $page_div .= "<h3 style=\"font-size:1em;font-weight:normal;\">Page ".$page_num."</h3>\n";       
+    } else { # PDF has less than 10 pages in total
+        $page_div .= "<h2 style=\"font-size:1em;font-weight:normal;\">Page ".$page_num."</h2>\n";       
     }
     }