Changeset 32541 for main/trunk/greenstone2/perllib/gssql.pm

Timestamp:

2018-10-25T20:12:42+13:00 (6 years ago)

Author:

ak19

Message:

Using proper parameters to GreenstoneSQLPlugin/Plugout instead of hardcoded values for params.

File:

• main/trunk/greenstone2/perllib/gssql.pm (modified) (4 diffs)

main/trunk/greenstone2/perllib/gssql.pm

@@ -106 +106 @@
 # TODO: Consider AutoCommit status (and Autocommit off allowing commit or rollback for GS coll build cancel) later
 
+# TODO: where should the defaults for these params be, here or in GS-SQLPlugin/Plugout?
 sub connect_to_db {
     my $self= shift (@_);
@@ -210 +211 @@
 # This will terminate if the db does not exist. Unlike load_db_and_tables() above, used by
 # GreenstoneSQLPlugout, this method will not attempt to create the requested db (nor its tables)
+# TODO: GS SQLPlugin is called before GS SQLPlugout and attempts to use_db() - called in plugin's
+# init() method. This will fail if the db does not exist. Ideally want our plugin only called
+# during buildcol.pl
 sub use_db {
     my $self= shift (@_);
@@ -294 +298 @@
 
 # Don't call this: it will delete the meta and full text tables for ALL collections in $db_name (localsite by default)!
-# this is just for debugging
+# This method is just here for debugging (for testing creating a database when there is none)
 sub _delete_database {
     my $self= shift (@_);
@@ -428 +432 @@
 # see https://www.perlmonks.org/bare/?node=DBI%20Recipes
 #    The page further has a table_exists function that could work with proper comparison
-# Couldn't get the first solution at https://www.perlmonks.org/bare/?node_id=500050 to work though
+# TODO: Couldn't get the first solution at https://www.perlmonks.org/bare/?node_id=500050 to work though
 sub table_exists {
     my $self = shift (@_);