Ignore:
Timestamp:
11/02/18 20:51:09 (2 years ago)
Author:
ak19
Message:

I think this is a bugfix to plugin.pm::remove_some(): when processing files to delete on deletion/reindexing, it would return after the first successful remove_one(). This wasn't a noticeable problem in the past since no plugin had a real need for implementing remove_one(). But now GS SQLPlugin does remove_one() in earnest, we need all the docs marked for deletion to be processed.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • main/trunk/greenstone2/perllib/plugins/GreenstoneSQLPlugin.pm

    r32563 r32565  
    228228    my $gs_sql = $self->{'gs_sql'} || return 0; # couldn't make the connection or no db etc
    229229    if(scalar @$oids > 1) {
    230     print STDERR "TODO: We now have reason to optimise GreenstoneSQLPlugin::remove_one() by using prepare and execute.\n";
     230    print STDERR "TODO: We now have reason to optimise GreenstoneSQLPlugin::remove_one() by using dbi::prepare() + dbi::execute() instead of dbi::do().\n";
    231231    }
    232232   
Note: See TracChangeset for help on using the changeset viewer.