Changeset 32571 for main/trunk/greenstone2/perllib/plugins

Timestamp:

2018-11-05T16:46:34+13:00 (5 years ago)

Author:

ak19

Message:

Optimised the SQL DB delete operations in case there are several in one building phase, by preparing the delete SQL statement once and storing it then executing it each time there's a delete, rather than calling do() which will both prepare the del SQL statement each time and execute it each time

File:

• main/trunk/greenstone2/perllib/plugins/GreenstoneSQLPlugin.pm (modified) (1 diff)

main/trunk/greenstone2/perllib/plugins/GreenstoneSQLPlugin.pm

@@ -230 +230 @@
     
     my $gs_sql = $self->{'gs_sql'} || return 0; # couldn't make the connection or no db etc
-    if(scalar (@$oids) > 1) {
-    print STDERR "TODO: As there's more than 1 docid, we now have reason to optimise GreenstoneSQLPlugin::remove_one() by using dbi::prepare() + dbi::execute() instead of dbi::do().\n";
-    }
     
     my $proc_mode = $self->{'process_mode'};