Changeset 32572


Ignore:
Timestamp:
11/05/18 19:06:16 (2 years ago)
Author:
ak19
Message:

Dr Bainbridge simplified my boolean expression when he checked my recent bugfix in plugin::remove_some() for correctness.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • main/trunk/greenstone2/perllib/plugin.pm

    r32566 r32572  
    268268        $rv = $plugobj->remove_one($file, $oids, $archivedir);
    269269        if (defined $rv && $rv != -1) {
    270         #return $rv;
    271270        $processed_file = 1;
    272271        last; # break and continue with outer for loop, to process other deleted files
    273272        } # else undefined (was not recognised by the plugin) or there was an error, try the next one
    274273    }
    275     #return 0;
    276274   
    277275    if (!$processed_file) { # no plugin could recognise file.
     
    279277        print STDERR "WARNING: plugin::remove_some() failed to process $file with oid(s) ". join(",", @$oids) . "\n";
    280278        #return 0;
    281         $all_files_processed_successfully = $processed_file && $all_files_processed_successfully;       
     279        $all_files_processed_successfully = 0;
    282280    } # else some plugin processed the current deleted file
    283281      # continue to process next deleted file
Note: See TracChangeset for help on using the changeset viewer.