Changeset 33072


Ignore:
Timestamp:
05/14/19 10:13:30 (2 years ago)
Author:
kjdon
Message:

DeleteItem service had never been implemented, only DeleteItems, despite the advertising for the service. Commenting DeleteItem code out so that its obvious it hasn't been implemented. Would we want it? easy enough to call DeleteItems... should just delete it next time?

File:
1 edited

Legend:

Unmodified
Added
Removed
  • main/trunk/greenstone3/src/java/org/greenstone/gsdl3/service/BerryBasket.java

    r32453 r33072  
    6464    protected static final String DELETE_ITEMS_SERVICE = "DeleteItems";
    6565    protected static final String SEND_MAIL_SERVICE = "SendMail";
    66     protected static final String DELETE_ITEM_SERVICE = "DeleteItem";
     66    //protected static final String DELETE_ITEM_SERVICE = "DeleteItem";
    6767
    6868  // for AddItem
     
    151151
    152152        // set up short_service_info_ - for now just has name and type
    153         Element deleteone_service = this.desc_doc.createElement(GSXML.SERVICE_ELEM);
    154         deleteone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
    155         deleteone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
    156         this.short_service_info.appendChild(deleteone_service);
     153        // Element deleteone_service = this.desc_doc.createElement(GSXML.SERVICE_ELEM);
     154        // deleteone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
     155        // deleteone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
     156        // this.short_service_info.appendChild(deleteone_service);
    157157
    158158        // set up short_service_info_ - for now just has name and type
     
    227227        }
    228228
    229         if (service_id.equals(DELETE_ITEM_SERVICE))
    230         {
    231 
    232             Element delone_service = doc.createElement(GSXML.SERVICE_ELEM);
    233             delone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
    234             delone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
    235             return delone_service;
    236         }
     229        // if (service_id.equals(DELETE_ITEM_SERVICE))
     230        // {
     231
     232        // Element delone_service = doc.createElement(GSXML.SERVICE_ELEM);
     233        // delone_service.setAttribute(GSXML.TYPE_ATT, "gather"); // what??
     234        // delone_service.setAttribute(GSXML.NAME_ATT, DELETE_ITEM_SERVICE);
     235        // return delone_service;
     236        // }
    237237
    238238        if (service_id.equals(SEND_MAIL_SERVICE))
Note: See TracChangeset for help on using the changeset viewer.