Changeset 33107

Timestamp:

2019-05-24T17:09:27+12:00 (5 years ago)

Author:

ak19

Message:

Minor optimisation to the double for loop that depends on the ordering of the selections being in the order of the checkboxes, and the order of the checkboxes being in the order of the docList ids.

File:

• main/trunk/greenstone3/web/interfaces/default/js/berrybasket/berrycheckout.js (modified) (1 diff)

main/trunk/greenstone3/web/interfaces/default/js/berrybasket/berrycheckout.js

@@ -123 +123 @@
     else { // Not deleting all berries, just a subset
         // Remove id of selected doc to be deleted from docList.        
-        // No ordering of berry indexes according to the order they're added,
-        // So can't optimise comparison further than traversing the docList array in reverse
+        // Minor optimisation to double for loop, dependent on ordering of selected berries being
+        // in order of checkboxes (i.e. order of docList ids), and order of docList ids having
+        // the same order as the checkboxes
+        var searchForNextSelectedIdFromIndex = idsToDelete.length-1;
         for (var i = docList.length - 1; i >= 0; i--) {
         var berry = docList[i];
         var berry_id = berry['collection'] + ":" + berry['name'];
         
-        for(var j = 0; j < idsToDelete.length; j++) {
+        for(var j = searchForNextSelectedIdFromIndex; j >= 0; j--) {
             if(idsToDelete[j] == berry_id) {
             docList.splice(i, 1); // i indexes into docList, delete element i from docList
+            searchForNextSelectedIdFromIndex = j-1;
             break;
             }