Changeset 33184 for main/trunk/greenstone3

Timestamp:

2019-06-21T17:16:16+12:00 (5 years ago)

Author:

wy59

Message:

1. Loop counter bugfix. 2. Not sure if there should be a scroll through markers option in doc view and if so, what it should do. For now, it's off by default in doc view but can be turned on, in which case it does not at the moment.

Location:

main/trunk/greenstone3/web/interfaces/default/js

Files:

• document_scripts.js (modified) (1 diff)
• map-scripts.js (modified) (1 diff)

main/trunk/greenstone3/web/interfaces/default/js/document_scripts.js

@@ -20 +20 @@
 var editableLastStates = new Array();
 
+// REDEFINING map-scripts::_scrollThroughDefault to be FALSE for document view
+_scrollThroughDefault = false; // TODO: should this even be there in doc view? And if so, what should it scroll through, all markers/shapes in coll or only those in doc?
 
 /********************

main/trunk/greenstone3/web/interfaces/default/js/map-scripts.js

@@ -424 +424 @@
     {
         var doc = _docList.getDocByIndex(i);
-        if(typeof doc.shapes !== 'undefined') {         
+        if(typeof doc.shapes !== 'undefined') {
             for(var x = 0; x < doc.shapes.length; x++) {
-                var shape = doc.shapes[i];
+                var shape = doc.shapes[x];
                 if(shape.type === google.maps.drawing.OverlayType.MARKER && shape.getVisible())
                 {