Changeset 34894

Timestamp:

2021-02-17T15:20:38+13:00 (3 years ago)

Author:

su41

Message:

Added in some error handling messages for mysql.

File:

• gs2-extensions/tipple-bridge/trunk/src/src/main/java/sqlCli.java (modified) (13 diffs)

gs2-extensions/tipple-bridge/trunk/src/src/main/java/sqlCli.java

@@ -1 +1 @@
 import com.google.gson.JsonArray;
+import com.mysql.cj.exceptions.MysqlErrorNumbers;
 import picocli.CommandLine;
 import picocli.CommandLine.Command;
@@ -27 +28 @@
     //our cli arguments
 
-    @Option(names = {"-u", "--user"}, description = "The user name")
+    @Option(names = {"-u", "--user"}, description = "The user name",
+            required = true)
     String userName;
 
@@ -37 +39 @@
     echo back) but on the IDE it will echo back.
      */
-    @Option(names = {"-p", "--password"}, description = "User's password", interactive = true)
+    @Option(names = {"-p", "--password"}, description = "User's password", interactive = true,
+            required = true)
     String password;
 
@@ -46 +49 @@
     String dbName;
 
+    //project id - it should be required right?
+    //if they omit, the query would come up empty.
     @Option(names = {"--projectID"}, description = "ID number of the project")
     String projectID;
 
     //defaultValue in case the user doesn't enter in an option for it
+    //make this option so that the program can read in without typing in --filename everytime
+    //read this option in last
     @Option(names = {"--fileName"}, description = "Name of output JSON file",
-            required = true, defaultValue = "myData.json")
+            required = true)
     String fileName;
 
@@ -70 +77 @@
 
     private static void databaseConnect(String user, String pass, int port, String dbName,
-                                        String projectID, String filename, String host){
+                                        String projectID, String fileName, String host){
         Connection conn;
         Statement stmt;
@@ -82 +89 @@
         // FileWriter file = new FileWriter("tippleData.json")
     System.out.println("Saving output to:");
-    System.out.println("  " + filename);
+    System.out.println("  " + fileName);
     
-        try (FileWriter file = new FileWriter(filename)){
+        try (FileWriter file = new FileWriter(fileName)){
             //register the jdbc driver
             Class.forName("com.mysql.cj.jdbc.Driver");
             //opening the connection
             System.out.println("Connecting to database:");
-        System.out.println("  " + dbUrl);
+            System.out.println("  " + dbUrl);
         
             conn = DriverManager.getConnection(dbUrl, user, pass);
@@ -96 +103 @@
             stmt = conn.createStatement();
             //remember to put in the projectId parameter instead of hardcoding it
+
+            /*
+            if we get up to the point where we allow boundary setting, i.e  user specifies
+            between x and y number of records
+            could use an if statement to check
+            if the paramter exists or not, if it does then run a statement with those x and y
+            if not, then run a different statement without them
+             */
+
             String sql = "SELECT name, id, typeId, created from td_ContentItem where projectId="+projectID;
 /*
@@ -110 +126 @@
             System.out.println("  Number of columns in table retrieved: " + dbColumn);
 
+            //create gson object and have the file write the opening bracket for valid json
             Gson myGSon = new Gson();
-        file.write("[");
+            file.write("[");
 
             //does nothing, assuming the try catch picks up the error first,
@@ -122 +139 @@
                 HashMap<String, Object> dbRow = new HashMap<String, Object>(dbColumn);
 
-                //maybe use some kind of arrayList?
-                // ArrayList<Map<String, Object>> dbRowArray = new ArrayList<>(dbColumn);
-
                 for(int i = 1; i <= dbColumn; i++){
                     /*
-                    doing checking this way would mean we have to have a case
+                    doing checking this way could mean we have to have a case
                     for every data type,
                     if a data type changes in the database that's probably fine, but
@@ -135 +149 @@
                     Without this kind of check though, the output would throw a pretty nasty
                     warning about illegal reflective access. Though it would still print the
-                    date out fine. Think it switched to using some other java option?
+                    date out fine. The warning:
 
                     WARNING: An illegal reflective access operation has occurred
-WARNING: Illegal reflective access by com.google.gson.internal.bind.ReflectiveTypeAdapterFactory (file:/home/su41/.gradle/caches/modules-2/files-2.1/com.google.code.gson/gson/2.7/751f548c85fa49f330cecbb1875893f971b33c4e/gson-2.7.jar) to field java.time.LocalDateTime.date
-WARNING: Please consider reporting this to the maintainers of com.google.gson.internal.bind.ReflectiveTypeAdapterFactory
-WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
-WARNING: All illegal access operations will be denied in a future release
+                    WARNING: Illegal reflective access by com.google.gson.internal.bind.ReflectiveTypeAdapterFactory (file:/home/su41/.gradle/caches/modules-2/files-2.1/com.google.code.gson/gson/2.7/751f548c85fa49f330cecbb1875893f971b33c4e/gson-2.7.jar) to field java.time.LocalDateTime.date
+                    WARNING: Please consider reporting this to the maintainers of com.google.gson.internal.bind.ReflectiveTypeAdapterFactory
+                    WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
+                    WARNING: All illegal access operations will be denied in a future release
                      */
                     if(resultMetaData.getColumnTypeName(i).equals("DATETIME")){
                         dbRow.put(resultMetaData.getColumnName(i), myResult.getDate(i));
-                        //System.out.println("has a datetime");
-
                     }
-
                     else{
                         dbRow.put(resultMetaData.getColumnName(i), myResult.getObject(i));
-                       // System.out.println("no datetime datetime");
                     }
                 }
-                //JsonObject jsonObject = myGSon.toJsonTree(dbRow).getAsJsonObject();
-
-                // using a hashmap wont work with this as its not an array
-               // JsonArray jsonArray = myGSon.toJsonTree(dbRow).getAsJsonArray();
                String dbRowAsJson = myGSon.toJson(dbRow);
 
@@ -168 +174 @@
 
                 file.write(dbRowAsJson);
-                //file.write(jsonArray.toString());
+
                 //Adding commas between each row that we write to our file, as we need it to be valid json
                 if(!myResult.isLast()){
@@ -183 +189 @@
             stmt.close();
             conn.close();
+            System.out.println("Connection closed");
+        }
+        catch(SQLException sqlError){
+            System.out.println("MySQL error code: " + sqlError.getErrorCode());
+            System.out.println(sqlError.getMessage());
+            //System.out.println(MysqlErrorNumbers.ER_ACCESS_DENIED_ERROR);
+           if(sqlError.getErrorCode() == MysqlErrorNumbers.ER_ACCESS_DENIED_ERROR){
+               System.out.println("Error with database credentials. Double check your: ");
+               System.out.println("    -'Username'");
+               System.out.println("    -'Password' ");
+               System.out.println("    -'Database name' ");
+            }
+            sqlError.printStackTrace();
+
         }
         catch(Exception e){
@@ -189 +209 @@
             //print out wrong username or password instead of the stack trace?
             System.out.println("encountered error");
+
         }
     }