Changeset 35291

Timestamp:

2021-08-13T20:38:34+12:00 (3 years ago)

Author:

davidb

Message:

Updated syntax to work with newer C compilers (e.g., gcc v10)

Location:

main/trunk/greenstone2/build-src/packages/rtftohtml

Files:

• rtftohtml-gs.tar.gz (modified) ( previous)
• rtftohtml-gs.txt (modified) (1 diff)

main/trunk/greenstone2/build-src/packages/rtftohtml/rtftohtml-gs.txt

@@ -55 +55 @@
 John McPherson ([email protected])
 June 2001.
+
+====
+When compiling with gcc v10, the following struct definition:
+
+struct SSStruct {
+        struct SDest SD;
+        int alloc;
+        int used;
+        struct SSData *data;
+} PNSave, FNSave;
+
+
+in:
+
+  htmlout.h
+
+caused a multiply defined linking error.
+
+The syntax used in the header file seeks to defined the struct 'SSStruct'
+and then introduce 2 global variables 'PNSave' and 'FNSave'.  It was
+reasoned that this style of declaring a struct and then declaring global
+variables of this type has probably been deprecated, then then officially
+discontinued (by gcc v10).  Rather than spending time delving into what
+is/isn't allowed in newer standards of C, the decision was made to
+simply rewrite the code so the actual declaration of the global variables
+was moved to htmlout.c
+
+David Bainbridge ([email protected])
+August 2021
+====