Changeset 35667 for main

Timestamp:

2021-10-22T14:38:34+13:00 (3 years ago)

Author:

davidb

Message:

Some notes on how to address deprecated warnings added

Location:

main/trunk/gli/src/org/greenstone/gatherer

Files:

• gems/MetadataSetTree.java (modified) (1 diff)
• gui/ConfigFileEditor.java (modified) (1 diff)
• util/XMLTools.java (modified) (1 diff)

main/trunk/gli/src/org/greenstone/gatherer/gems/MetadataSetTree.java

@@ -107 +107 @@
     public void mouseReleased(MouseEvent event) { }
 
+
+    // Observer/Obserable became deprecated in JDK9 onwards, although with no set date for removal.
+    // If looking to replace use of Observer/Obserable, then using java.bean.PropertyChangeLister
+    // and PropertyChangeEvent is (StackOverflow) cited go to.
+    // For a worked example comparing the two different approaches, see:
+    //
+    //   https://gist.github.com/mtorchiano/e69ac7e309fee81bd17f4f0740b9ffa9
+    //   Replacing Observer-Observable (inheritance vs. composition)
+    
     public void update(Observable o,Object arg){ 
         if (arg !=null){

main/trunk/gli/src/org/greenstone/gatherer/gui/ConfigFileEditor.java

@@ -589 +589 @@
     public void keyPressed(KeyEvent key_event)
     {
+        // **** getModifiers() in InputEvent has been deprecated  
+        //   Oracle directs you to use getModifiersEx() which is an extended version that
+        //   has been more carefully constructed.
+        // 
+
+        //  int onmask = SHIFT_DOWN_MASK | BUTTON1_DOWN_MASK;
+        //  int offmask = CTRL_DOWN_MASK;
+        //  if ((event.getModifiersEx() & (onmask | offmask)) == onmask) {
+        //    // ...
+        //  }
+
+        // The above code excerpt is from:
+        //   https://docs.oracle.com/javase/10/docs/api/java/awt/event/InputEvent.html
+        //
+        // In working through changes to avoid using this deprecated call, as similar
+        // change from using getMenuShortcutKeyMask() to getMenuShortcutKeyMaskEx()
+        // will be needed.
+        
+        
         // Don't hardcode check for Ctrl key "(e.getModifiers() & KeyEvent.CTRL_MASK) != 0)"
         // because Mac uses another modifier key, Command-F instead of Ctrl-F.

main/trunk/gli/src/org/greenstone/gatherer/util/XMLTools.java

@@ -936 +936 @@
         try
         {
+            // OutputFormat() and XMLSerlalizer() have been deprecated
+            // StackOverflow suggested alternative is to use LSSerializer class from the package org.w3c.dom.ls
+            // Some example code doing this at:
+            // https://stackoverflow.com/questions/55729019/xmlserializer-outputformat-deprecated
+            
             OutputStream os = new FileOutputStream(xml_file);
             // Create an output format for our document.