Changeset 36808

Timestamp:

2022-10-16T18:52:02+13:00 (18 months ago)

Author:

anupama

Message:

We used to run diffcol as a nightly task only for GS2. Commit 36655 was the first stage of getting diffcol to work for GS3, but skipped a lot of important code branches (like comparing the index\text\j/gdb files) in order to fix up the easier parts of the code. Now that I think the remainder of the diffcol scripts have been got to work with diffcol for GS3, where the index\text\flatdb files are compared and diffcol works for them, I can commit the important changes as well as commented out debugging statements made to the diffcol scripts that get the full diffcol code to work for GS3 diffcol. I will recommit again after removing the debugging statements. And I still need to do a full local diffcol run again, as well as testing if diffcol still works after locally undoing my sort field changes to some GS3 model cols (the recent commits to Tudor, Word-PDF, Images-GPS and Multimedia collections) to see if Dr Bainbridge's PERL_HASH_SEED env var addition fixes all of those collections diffcol failures, making the extra sorting redundant. In that case, I will recommit those model collections after updating their col configurations to not do the extra sorting.

File:

• other-projects/nightly-tasks/diffcol/trunk/diffcol/cfgdiff.pm (modified) (1 diff)

other-projects/nightly-tasks/diffcol/trunk/diffcol/cfgdiff.pm

@@ -21 +21 @@
     if($cfg_file eq "build.cfg")
     {
-    my @temp_array = split (" ",$cfg_result);
-    my @r_array =  grep {/\d+/} @temp_array;
+        my @temp_array = split (" ",$cfg_result);
+        my @r_array =  grep {/\d+/} @temp_array;
 
-    if ($cfg_result eq "")
-    {
-        return "";
-#       return "Difference Report: These two collections are identical";
-    }
-    elsif ($r_array[1] > $r_array[2] && $temp_array[2] eq "builddate" && $temp_array[6] eq "builddate")
-    {
-        return "Difference Report: Using newer collection as model collection";
-    }
-    elsif ($r_array[1] < $r_array[2] && $temp_array[2] eq "builddate" && $temp_array[6] eq "builddate")
-    {
-        return "";
-    }
-    else
-    {
-        $cfg_result = &diffutil::GenerateOutput($cfg_result,"");
-        return $cfg_result;
-    }
+        if ($cfg_result eq "")
+        {
+            return "";
+    #       return "Difference Report: These two collections are identical";
+        }
+        elsif ($r_array[1] > $r_array[2] && $temp_array[2] eq "builddate" && $temp_array[6] eq "builddate")
+        {
+            return "Difference Report: Using newer collection as model collection";
+        }
+        elsif ($r_array[1] < $r_array[2] && $temp_array[2] eq "builddate" && $temp_array[6] eq "builddate")
+        {
+            return "";
+        }
+        else
+        {
+            $cfg_result = &diffutil::GenerateOutput($cfg_result,"");
+            return $cfg_result;
+        }
     }
     elsif($cfg_file eq "collect.cfg")
     {
 
-    $cfg_result = &diffutil::GenerateOutput($cfg_result,"");
-    if ($cfg_result eq "")
-    {
-        return "";
-    }
-    else
-    {
-        return "Difference Report:\n$cfg_result";
-    }
+        $cfg_result = &diffutil::GenerateOutput($cfg_result,"");
+        if ($cfg_result eq "")
+        {
+            return "";
+        }
+        else
+        {
+            return "Difference Report:\n$cfg_result";
+        }
     }
     else
     {
-    die "Error occour in cfgdiff::testcfg!!\n";
+        die "Error occour in cfgdiff::testcfg!!\n";
     }
 }