Changeset 36906 for main/trunk/greenstone3/web/interfaces/default/js/utility_scripts.js

Timestamp:

2022-11-15T13:59:16+13:00 (17 months ago)

Author:

kjdon

Message:

check whether TKMetadataURL is defined before using it - get success result when doing ajax url to undefined.

File:

• main/trunk/greenstone3/web/interfaces/default/js/utility_scripts.js (modified) (4 diffs)

main/trunk/greenstone3/web/interfaces/default/js/utility_scripts.js

@@ -178 +178 @@
       "MenRestricted","WomenRestricted","CulturallySensitive","SecretSacred","OpenToCommercialization","NonCommercial","CommunityUseOnly","Outreach","OpenToCollaboration"];
    let tkCodes = ["tk_a","tk_cl","tk_f","tk_mc","tk_cv","tk_cr","tk_v","tk_nv","tk_s","tk_wg","tk_mg","tk_mr","tk_wr","tk_cs","tk_ss","tk_oc","tk_nc","tk_co","tk_o","tk_cb"];
-   for (let i = 0; i < tkLabels.length; i++) {
+    for (let i = 0; i < tkLabels.length; i++) {
       if (labelName == tkLabels[i]) {
          let labeldiv = document.querySelectorAll(".tklabels img");
          for (image of labeldiv) {
-            let labelCode = image.src.substr(image.src.lastIndexOf("/") + 1).replace(".png", ""); // get tk label code from image file name
-            if (labelCode == tkCodes[i]) {
+             let labelCode = image.src.substr(image.src.lastIndexOf("/") + 1).replace(".png", ""); // get tk label code from image file name
+             if (labelCode == tkCodes[i]) {
                image.title = "TK " + name + ": " + definition + " Click for more details."; // set tooltip
                if (image.parentElement.parentElement.parentElement.classList[0] != "tocSectionTitle") { // disable onclick event in favourites section
@@ -225 +225 @@
       console.error("ajax call not yet loaded tk label metadata set");
    } else {
-      for (label of tkMetadataElements) { // for each tklabel element in tk.mds
+       for (label of tkMetadataElements) { // for each tklabel element in tk.mds
          let tkLabelName = label.attributes.name.value; // Element name=""
          let attributes = label.querySelectorAll("[code=" + lang + "] Attribute"); // gets attributes for selected language
@@ -260 +260 @@
 };
 function loadTKMetadataSet(lang, type) {
-   tkMetadataSetStatus = "loading";
+    if (gs.variables["tkMetadataURL_"+type] == undefined) {
+    console.error("tkMetadataURL_"+type+" variable is not defined, can't load TK Metadata Set");
+    tkMetadataSetStatus = "no-metadata-set-for-this-"+type;
+    return;
+    }
+    tkMetadataSetStatus = "loading";
    $.ajax({
        url: gs.variables["tkMetadataURL_"+type],
        async: false,
-      success: function(xml) {
+       success: function(xml) {
          tkMetadataSetStatus = "loaded";
          let parser = new DOMParser();
          let tkmds = parser.parseFromString(xml, "text/xml");
          tkMetadataElements = tkmds.querySelectorAll("Element");
-         if (document.readyState === "complete") {
+           if (document.readyState === "complete") {
             addTKLabelsToImages(lang);
-         } else {
-            window.onload = function() {
+           } else {
+               window.onload = function() {
                addTKLabelsToImages(lang);
             }
@@ -278 +283 @@
       },
       error: function() {
-         tkMetadataSetStatus = "no-metadata-set-for-this-"+type;
-         console.log("No TK Label Metadata-set found for this "+type);
+          tkMetadataSetStatus = "no-metadata-set-for-this-"+type;
+      console.log("No TK Label Metadata-set found for this "+type);
       }
    });