Changeset 5599

Timestamp:

2003-10-07T17:12:44+13:00 (21 years ago)

Author:

jrm21

Message:

added important piece of feedback so that if the tmp dir isn't writeable, we
immediately say so instead of failing silently and causing later problems.

Location:

trunk/gsdl/src/recpt

Files:

• collectoraction.cpp (modified) (3 diffs)
• collectoraction.h (modified) (1 diff)

trunk/gsdl/src/recpt/collectoraction.cpp

@@ -324 +324 @@
 
     // assign (and create) a temporary directory 
-    assign_tmpname (args, logout);
+    if (assign_tmpname (args, logout)==false) {
+      // there was an error creating the tmp dir
+      message="tmpfail";
+      return true; // true because we could still parse the arguments
+    }
 
     // clean up any old builds left laying about in the tmp directory
@@ -1542 +1546 @@
 // assigns a temporary directory name for this collector session
 // and creates temporary directory
-void collectoraction::assign_tmpname (cgiargsclass &args, ostream &logout) {
+// returns false if it couldn't create the directory
+bool collectoraction::assign_tmpname (cgiargsclass &args, ostream &logout) {
 
   int i = 0;
@@ -1556 +1561 @@
     logout << text_t2ascii << "collectoraction::assign_tmpname unable to create directory ("
        << fulltmpdir << ")\n";
+    return false;
   }
 
   args["bc1tmp"] = tmpname;
+  return true;
 }
 

trunk/gsdl/src/recpt/collectoraction.h

@@ -77 +77 @@
   bool collection_protected (const text_t &collection);
 
-  void assign_tmpname (cgiargsclass &args, ostream &logout);
+  bool assign_tmpname (cgiargsclass &args, ostream &logout);
 
   void gsdl_mkcol (cgiargsclass &args, ostream &logout);