Changeset 8129

Timestamp:

2004-09-21T13:29:32+12:00 (20 years ago)

Author:

mdewsnip

Message:

Changed two functions to return a clone of the important list of each class, so it cannot be modified from outside code.

Location:

trunk/gli/src/org/greenstone/gatherer/metadata

Files:

• MetadataSet.java (modified) (1 diff)
• MetadataSetManager.java (modified) (2 diffs)

trunk/gli/src/org/greenstone/gatherer/metadata/MetadataSet.java

@@ -120 +120 @@
     public ArrayList getMetadataSetElements()
     {
-    return metadata_set_elements;
+    // We don't want anyone to modify the list, so return a copy of it
+    return (ArrayList) metadata_set_elements.clone();
     }
 

trunk/gli/src/org/greenstone/gatherer/metadata/MetadataSetManager.java

@@ -57 +57 @@
 
     // Not found
-    System.err.println("No metadata set with namespace " + metadata_set_namespace + " found.");
+    // System.err.println("No metadata set with namespace \"" + metadata_set_namespace + "\" found.");
     return null;
     }
@@ -64 +64 @@
     static public ArrayList getMetadataSets()
     {
-    return metadata_sets;
+    // We don't want anyone to modify the list, so return a copy of it
+    return (ArrayList) metadata_sets.clone();
     }