Changeset 9185

Timestamp:

2005-02-25T14:24:48+13:00 (19 years ago)

Author:

mdewsnip

Message:

Fix to the bug with Java 1.5.0 where the checkbox would not repaint if it was clicked while the item was selected.

File:

• trunk/gli/src/org/greenstone/gatherer/util/CheckList.java (modified) (4 diffs)

trunk/gli/src/org/greenstone/gatherer/util/CheckList.java

@@ -66 +66 @@
     setModel(new DefaultListModel());
     setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
-    addMouseListener(new CheckListListener());
+    addMouseListener(new CheckListMouseListener());
     }
 
@@ -153 +153 @@
 
 
-    private void selectionChanged(int index) {
-    fireSelectionValueChanged(index, index, false);
-    }
-
-
     /** A custom list cell renderer for producing rows which contain clickable check boxes. */
     protected class CheckListCellRenderer 
-    implements ListCellRenderer {
-
+    implements ListCellRenderer
+    {
     /** Return a component that has been configured to display the specified value. That component's paint method is then called to "render" the cell. If it is necessary to compute the dimensions of a list because the list cells do not have a fixed size, this method is called to generate a component on which getPreferredSize  can be invoked.
      * @param list The </strong>JList</strong> we're painting.
@@ -172 +167 @@
     public Component getListCellRendererComponent(JList list, Object value, int index, boolean is_selected, boolean cell_has_focus) {
         JCheckBox checkbox = (JCheckBox) value;
-        if(show_selected_row) {
+        if (show_selected_row) {
         checkbox.setBackground(is_selected ? list.getSelectionBackground() : list.getBackground());
         checkbox.setForeground(is_selected ? list.getSelectionForeground() : list.getForeground());
@@ -192 +187 @@
 
     /** Listens for clicks apon the checks within the list, and updates as necessary. */
-    private class CheckListListener 
-    extends MouseAdapter {
-
+    private class CheckListMouseListener 
+    extends MouseAdapter
+    {
     /** Called whenever the mouse is clicked over our list. We find the nearest checkbox and change its state.
      * @param e A <strong>MouseEvent</strong> containing everything you ever wanted to know about the mouse event but were afraid to ask.
      */
-    public void mousePressed(MouseEvent e) {
+    public void mousePressed(MouseEvent e)
+    {
         JList list = (JList) e.getSource();
         int index = list.locationToIndex(e.getPoint());
-        CheckListEntry checkbox = (CheckListEntry)list.getModel().getElementAt(index);
-        if(!checkbox.isFixed()) {
+        CheckListEntry checkbox = (CheckListEntry) list.getModel().getElementAt(index);
+        if (!checkbox.isFixed()) {
         checkbox.setSelected(!checkbox.isSelected());
         }
         checkbox.grabFocus();
-        // Fire a selection changed event
-        selectionChanged(index);
+
+        // This is necessary to get the checkbox to repaint in Java 1.5.0
+        list.getSelectionModel().clearSelection();
     }
     }