Opened 15 years ago

Closed 15 years ago

#393 closed defect (duplicate)

RemoteGreenstoneServer and GLIApplet tasks

Reported by: ak19 Owned by: ak19
Priority: high Milestone: Release 2.81
Component: GLI Severity: major
Keywords: RemoteGreenstoneServer, GLIapplet Cc:

Description

  1. Thread problem: random infinite wait for next action in queue when the queue should actually already contain the next action
  2. When the username/password typed in at the startup of GLI is wrong, keeps popping up invalid authentication dialog
  3. exit condition when user presses cancel, or on connectexception should quit while(true) loop in ActionQueue.java's run() and Gatherer should exit()
  4. New bug: GLIapplet used to build and preview a collection, then browser pointed elsewhere before user returns to open the GLI applet and rebuilds the collection. On clicking preview the browser crashes.
  • Fixed: Bug in GLIapplet since 2.80 and after. If after using the GLIapplet, the user pointed the browser elsewhere and returned to the GLIapplet, this would cause the reloading of GLIapplet to wait forever.

Fixed by making RemoteGreenstoneServer class into an OOP class rather than being filled with static methods and variables. Now this class is split into 3, the other two being RemoteGreenstoneServerAction.java and ActionQueue.java

Change History (7)

comment:1 by ak19, 15 years ago

Another task

  1. When working with the GLI client against a remote GS server, files with French filenames are zipped in such a way that the original encoding is ruined. This means that the files the remote greenstone server receives have the wrong filenames and things go wrong from there (interlinking, file display names, missing images in htmls).

comment:2 by ak19, 15 years ago

  • 1, 2 and 3 done. (1 appears to be done, since I tested it about 50-75 times and the random occurrence of an infinite wait didn't appear then.)
  • 4 is for the next release since 2.80 didn't even load the GLIapplet when you return to the page after visiting another.

comment:3 by ak19, 15 years ago

For 5. the solution maybe to check whether 7-zip can handle such filenames and if so, to consider moving to a Java-based solution that uses a 7-zip API.

comment:4 by ak19, 15 years ago

  1. Consider turning authentication task into an Action as well, by adding a ping command on the gliserver.pl end that is sent the username and password and which it can verify. This may help with 4.
  1. Applet: If either the gliserver.pl or authentication weren't provided, then pressing the Launch GLI button should once again ask for whichever piece of data was missing before GLI itself is launched.

comment:5 by ak19, 15 years ago

Found a bug that I must have introduced, it is not there in 280bin:

Download panel.

When I download from one url and view the log, things are fine. Then when I download from another url and view the log, there's exceptions in GLI.

comment:6 by ak19, 15 years ago

Solved bug in entry 2008-11-03 12:56:10 above: The solution is in gli's download/DownloadScrollPane.java, where the run() method has to test that the job is not null before proceeding to callDownload(). The thread would loop forever and that's why there was an infinite exception in GLI when trying to view the log for a download job from a new URL.

comment:7 by ak19, 15 years ago

Resolution: duplicate
Status: newclosed

Closing off this ticket as the remaining items on this list that are yet to be fixed have been moved to a new ticket (#432).

Note: See TracTickets for help on using tickets.