GS3 build.xml os.windows property should not require constant maintenance
|Reported by:||ak19||Owned by:||ak19|
|Component:||Greenstone3 Ant Code||Severity:||major|
GS3 build.xml contains the following property definition for os.windows, which is used in target start-tomcat to check whether the OS is windows and if so, to run tomcat.
<property name="os.windows" value="Windows 95,Windows 98,Windows 2000,Windows 2003,Windows XP,Windows NT,Windows ME,Windows Vista,Windows 7,Windows Server 2008,Windows Server 2008 R2"/> <!-- check this!!!-->
Before "Windows Server 2008 (R2)" was in the list, it had failed to run on a Windows Server 2008 R2 machine until Shaoqun discovered and fixed this oversight in build.xml that prevented tomcat from starting on Windows Server 2008 RT.
She has identified the larger problem of build.xml having to maintain a list of what OS names constitute Windows. Newer OS will require constant updating. The suggestion is that we should define the property os.windows to somehow resolve to any string that matches the prefix of "Windows" so that this part of the code doesn't need constant maintenance or else results in tomcat silently failing to start (with no error messages or anything to indicate what happened).