Changeset 16331

Timestamp:

2008-07-10 12:56:42 (3 months ago)

Author:

ak19

Message:

Fixed a bug in showXMLParseFailureLine() and it now informs the debugger when there's a newline or empty space before the start of the xml tags (this won't be clear from the erroneous line that's printed out, since that line will be empty.

Files:

• gli/trunk/src/org/greenstone/gatherer/util/XMLTools.java (modified) (2 diffs)

gli/trunk/src/org/greenstone/gatherer/util/XMLTools.java

@@ -493 +493 @@
-     */
-    public static void showXMLParseFailureLine(SAXParseException e, String xmlContents) {
+        
+        // There should be no characters at all that preceed the <?xml>... bit. 
+        // The first check is for starting spaces:
+        if(xmlContents.startsWith("\n") || xmlContents.startsWith(" ") || xmlContents.startsWith("\t")) {
+            DebugStream.println("ERROR: illegal start of XML. Space/tab/newline should not preceed xml declaration.\n");
+            DebugStream.println("xmlContents (length is " + xmlContents.length() + "):\n" + xmlContents);
+            return; // nothing more to do, first error identified
+        }
+
-        // the actual line (String literal) where parsing failed and the SAXParseException occurred.
-        String line = "";
@@ -504 +513 @@
-                for(int i = 1; i <= linenumber; i++) {
-                    end = xmlContents.indexOf("\n");
-
+
+
+
-                    start = end+1;
-                }