Changeset 22693

Show
Ignore:
Timestamp:
19.08.2010 23:40:25 (9 years ago)
Author:
davidb
Message:

'multiplevalue' appears to be left undefined -- in general for all args being set. In the case of 'sqlsf' this lead to a conflict-warning message. The current fix, sorts out the problem in this one case, but looks like a more general solution should be implemented. This could be as simple as ensuring sensible default values in its constructor

Location:
main/trunk/greenstone2/runtime-src/src/recpt
Files:
2 modified

Legend:

Unmodified
Added
Removed
  • main/trunk/greenstone2/runtime-src/src/recpt/queryaction.cpp

    r22046 r22693  
    316316   
    317317 
     318  // **** 
     319  // should this even be here??? 
     320  // seems to be mixed up between "sf" and "sqlsf" 
     321 
    318322  // "sf" - Sort field. Set to field to be used for sorting search reult 
    319323  // set (only implemented for lucene collections at present). 
     
    321325  arg_ainfo.longname = "sql sort field"; 
    322326  arg_ainfo.multiplechar = true; 
     327  arg_ainfo.multiplevalue = false; 
    323328  arg_ainfo.defaultstatus = cgiarginfo::weak; 
    324329  arg_ainfo.argdefault = g_EmptyText; 
  • main/trunk/greenstone2/runtime-src/src/recpt/sqlqueryaction.cpp

    r22044 r22693  
    100100  argsinfo.addarginfo (NULL, arg_ainfo); 
    101101 
     102  // **** 
     103  // Looks like 'multiplevalue' is left undefined (e.g. not set in 
     104  // constructor).  This looks like a fairly major problem 
     105  // in terms of leaving it undefine 
     106  // => in the case of "sqlsf" leads to conflict over value it has 
     107 
    102108  // "sqlsf" - Sort field. Set to field to be used for sorting search reult 
    103109  // set  
     
    105111  arg_ainfo.longname = "sql sort field"; 
    106112  arg_ainfo.multiplechar = true; 
     113  arg_ainfo.multiplevalue = false; 
    107114  arg_ainfo.defaultstatus = cgiarginfo::weak; 
    108115  arg_ainfo.argdefault = g_EmptyText;