Changeset 18320 for gsdl/trunk/perllib/plugins/HTMLPlugin.pm

Timestamp:

2009-01-06T19:03:58+13:00 (15 years ago)

Author:

ak19

Message:

Now plugins provide the option of base64 encoding or url encoding filenames that are to be renamed (when copied into the archives dir). Previously renamed files would always be url-encoded. URL-encoding is the default now for most plugins except MP3Plugin and OggVorbisPlugin, where the default is base64 encoding. Base64 encoding filenames upon renaming them was introduced so that more files that browsers try to open in external applications can open them, since url encoding does not seem to be implemented the same everywhere (for instance, windows media player is unable to handle url-encoded wmv filenames when such files are launched in it through the browser).

File:

• gsdl/trunk/perllib/plugins/HTMLPlugin.pm (modified) (2 diffs)

gsdl/trunk/perllib/plugins/HTMLPlugin.pm

@@ -635 +635 @@
 # Given a filename in any encoding, will URL decode it to get back the original filename
 # in the original encoding. Because this method is intended to work out the *original* 
-# filename*, it not URL decode any filename if a file by the name of the *URL-encoded*
+# filename*, it does not URL decode any filename if a file by the name of the *URL-encoded*
 # string already exists in the local folder.
 # Return the original filename corresponding to the parameter URL-encoded filename, and
@@ -1140 +1140 @@
     }
 
-    # Make sure this name uses only ASCII characters 
-    # => use URL encoding, as it preserves original encoding
-    $newname = &unicode::url_encode($newname);
+    # Make sure this name uses only ASCII characters. 
+    # We use either base64 or URL encoding, as these preserve original encoding
+    $newname = &util::rename_file($newname, $self->{'file_rename_method'});
 
     $doc_obj->associate_file($filename, $newname, undef, $section);