Changeset 35242 for gs3-extensions/atea-nlp-tools/trunk/src/koreromaori-proxy/src/main/java/org/atea/nlptools/koreromaoriinterface/TranscriptionServlet.java

Timestamp:

2021-08-03T17:12:35+12:00 (3 years ago)

Author:

davidb

Message:

Improve error handling for calls to the Reo Tuhituhi API

File:

• gs3-extensions/atea-nlp-tools/trunk/src/koreromaori-proxy/src/main/java/org/atea/nlptools/koreromaoriinterface/TranscriptionServlet.java (modified) (4 diffs)

gs3-extensions/atea-nlp-tools/trunk/src/koreromaori-proxy/src/main/java/org/atea/nlptools/koreromaoriinterface/TranscriptionServlet.java

@@ -23 +23 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.atea.nlptools.koreromaoriinterface.exceptions.ReoTuhituhiException;
 import org.atea.nlptools.koreromaoriinterface.models.AudioFilePart;
 import org.atea.nlptools.koreromaoriinterface.models.MyTranscriptionResponse;
@@ -87 +88 @@
         String[] audioFileKeys = audioFileKeysParameter.split("\\|");
 
+        // Create our own representation of each part
         ArrayList<AudioFilePart> audioFileParts = new ArrayList<AudioFilePart>(audioFileKeys.length);
         for (String audioFileKey : audioFileKeys)
@@ -95 +97 @@
         }
 
-        try
+        try 
         {
-            List<AudioFilePart> results = transcriptionService.GetTranscriptions(audioFileParts);
+            List<AudioFilePart> results = transcriptionService.getTranscriptions(audioFileParts);
+
             List<MyTranscriptionResponse> responses = new ArrayList<MyTranscriptionResponse>(results.size());
-
             for (AudioFilePart result : results) {
                 responses.add(MyTranscriptionResponse.FromTranscriptionResult(result.getTranscriptionResult(), result.fileName));
@@ -107 +109 @@
             writer.append(json);
         }
+        catch (ReoTuhituhiException rtex)
+        {
+            response.sendError(502, "Call to the Reo Tuhituhi API failed.");
+        }
         catch (Exception ex)
         {
-            response.sendError(500, "Call to the Reo Tuhituhi API failed." + ex);
+            response.sendError(500, "Failed to process the request.");
             logger.error("Failed to complete API call", ex);
         }