unhelpful error message from GLI for malformed PluginList

[dmn]

This message fails to even say what file it was trying to read or what collection its trying to open:

---

Greenstone Librarian Interface (GLI) Copyright (C) 2006, New Zealand Digital Library Project, University Of Waikato GLI comes with ABSOLUTELY NO WARRANTY; for details see LICENSE.txt This is free software, and you are welcome to redistribute it

Checking GSDL3: /research/cc108/greenstone3 Checking GSDL: /research/cc108/greenstone3/gs2build Checking Perl: /usr/bin/perl Checking Java: /opt/jdk1.5.0_10/bin/java

Running the Greenstone Librarian Interface... Version: trunk

SAX exception: The element type "PluginList" must be terminated by the matching end-tag "</PluginList>". org.xml.sax.SAXParseException: The element type "PluginList" must be terminated by the matching end-tag "</PluginList>".

at org.apache.xerces.framework.XMLParser.reportError(XMLParser.java:1196) at org.apache.xerces.framework.XMLDocumentScanner.reportFatalXMLError(XMLDocumentScanner.java:635) at org.apache.xerces.framework.XMLDocumentScanner$ContentDispatcher.endOfInput(XMLDocumentScanner.java:1462) at org.apache.xerces.framework.XMLDocumentScanner.endOfInput(XMLDocumentScanner.java:418) at org.apache.xerces.validators.common.XMLValidator.sendEndOfInputNotifications(XMLValidator.java:694) at org.apache.xerces.readers.DefaultEntityHandler.changeReaders(DefaultEntityHandler.java:1026) at org.apache.xerces.readers.XMLEntityReader.changeReaders(XMLEntityReader.java:168) at org.apache.xerces.readers.AbstractCharReader.changeReaders(AbstractCharReader.java:150) at org.apache.xerces.readers.AbstractCharReader.scanContent(AbstractCharReader.java:1097) at org.apache.xerces.framework.XMLDocumentScanner$ContentDispatcher.dispatch(XMLDocumentScanner.java:1150) at org.apache.xerces.framework.XMLDocumentScanner.parseSome(XMLDocumentScanner.java:381) at org.apache.xerces.framework.XMLParser.parse(XMLParser.java:1081) at org.greenstone.gatherer.util.XMLTools.parseXML(XMLTools.java:436) at org.greenstone.gatherer.greenstone.Plugins.parsePluginsListXML(Plugins.java:302) at org.greenstone.gatherer.greenstone.Plugins.loadPluginsList(Plugins.java:232) at org.greenstone.gatherer.Gatherer.init(Gatherer.java:486) at org.greenstone.gatherer.Gatherer.<init>(Gatherer.java:217) at org.greenstone.gatherer.GathererProg.main(GathererProg.java:78)

java.lang.NullPointerException

at org.greenstone.gatherer.greenstone.Plugins.parsePluginsListXML(Plugins.java:303) at org.greenstone.gatherer.greenstone.Plugins.loadPluginsList(Plugins.java:232) at org.greenstone.gatherer.Gatherer.init(Gatherer.java:486) at org.greenstone.gatherer.Gatherer.<init>(Gatherer.java:217) at org.greenstone.gatherer.GathererProg.main(GathererProg.java:78)

[kjdon]

Can we catch this exception and print a better message? Will need to stop GLI if it happens.

[ak19]

Replying to kjdon:

Can we catch this exception and print a better message? Will need to stop GLI if it happens.

"org.greenstone.gatherer.util.XMLTools.parseXML(XMLTools.java:436)" If you now run GLI/FLI with the -debug flag on, then the recently added code in XMLTools' parseXML() method will show the line (string literal) of 'XML' where the parsing failed and due to which the SAXParseException was thrown. GLI will then exit. (Without the -debug flag it will only tell you to run it with -debug on if you want to see where it went wrong, but will not cause GLI to exit.)