Opened 13 years ago

Closed 13 years ago

#254 closed defect (fixed)

ant: prepare-tomcat failure because of hard-coded version numbers in build.xml

Reported by: dmn Owned by: kjdon
Priority: moderate Milestone: 3.04 Release
Component: Greenstone3 Ant Code Severity: blocker
Keywords: Cc:

Description

do we have the tomcat version number hard-coded somewhere?

prepare-tomcat:

[mkdir] Created dir: /home/daven/research/greenstone3-ui/customizingGreenstone3/packages

[get] Getting: http://www.greenstone.org/gs3files/apache-tomcat-5.5.12.zip [get] To: /home/daven/research/greenstone3-ui/customizingGreenstone3/packages/apache-tomcat-5.5.12.zip [get] Error opening connection java.io.FileNotFoundException: http://www.greenstone.org/gs3files/apache-tomcat-5.5.12.zip [get] Error opening connection java.io.FileNotFoundException: http://www.greenstone.org/gs3files/apache-tomcat-5.5.12.zip [get] Error opening connection java.io.FileNotFoundException: http://www.greenstone.org/gs3files/apache-tomcat-5.5.12.zip [get] Can't get http://www.greenstone.org/gs3files/apache-tomcat-5.5.12.zip to /home/daven/research/greenstone3-ui/customizingGreenstone3/packages/apache-tomcat-5.5.12.zip

BUILD FAILED /home/daven/research/greenstone3-ui/customizingGreenstone3/build.xml:532: Can't get http://www.greenstone.org/gs3files/apache-tomcat-5.5.12.zip to /home/daven/research/greenstone3-ui/customizingGreenstone3/packages/apache-tomcat-5.5.12.zip

Change History (4)

comment:1 by dmn, 13 years ago

ah its here:

http://trac.greenstone.org/browser/greenstone3/trunk/build.xml#L546

<get src="http://www.greenstone.org/gs3files/apache-tomcat-5.5.25.zip"
      dest="${packages.home}/apache-tomcat-5.5.25.zip"
	      usetimestamp="true"/>

Could we have a 'latest' option which was a symbolic link to the actual latest zip file?

http://www.greenstone.org/gs3files/apache-tomcat-latest

and similarly:

http://trac.greenstone.org/browser/greenstone3/trunk/build.xml#L664

and here:

http://trac.greenstone.org/browser/greenstone3/trunk/build.xml#L677

These don't look like good future-proofed approaches to me.

comment:2 by dmn, 13 years ago

Summary: ant prepare-tomcat failureant: prepare-tomcat failure because of hard-coded version numbers in build.xml

comment:3 by kjdon, 13 years ago

Component: Greenstone3 RuntimeGreenstone3 Ant Code
Severity: blocker

comment:4 by kjdon, 13 years ago

Resolution: fixed
Status: newclosed

When we change to different versions of tomcat, sometimes other things have to change (eg web.xml, or changes to tomcats files). So I think we do want to keep the version number in the code so that you get the right one. This means that we need to keep old versions available for download for people with old versions of greenstone.

I have moved the version numbers into properties near the start of build.xml, so its easier to change if necessary.

Note: See TracTickets for help on using tickets.