Changeset 16688 for greenstone3/trunk/src/java/org/greenstone/gsdl3/core/MessageRouter.java

Timestamp:

2008-08-08T13:23:59+12:00 (16 years ago)

Author:

davidb

Message:

Changed 'Element process(Element)' in ModuleInterface to 'Node process(Node)'. After some deliberation is was decided this is a more useful (generic) layer of the DOM to pass information around in. Helps with the DocType problem when producing XSL Transformed pages, for example. When this was an Element, it would loose track of its DocType. Supporting method provided in XMLConverter 'Element nodeToElement(Node)' which checks a nodes docType and casts to Element if appropriate, or if a Document, typecasts to that and then extracts the top-level Element. With this fundamental change in ModuleInterface, around 20 files needed to be updated (Actions, Services, etc) that build on top of 'process()' to reflect this change, and use nodeToElement where necessary.

File:

• greenstone3/trunk/src/java/org/greenstone/gsdl3/core/MessageRouter.java (modified) (3 diffs)

greenstone3/trunk/src/java/org/greenstone/gsdl3/core/MessageRouter.java

@@ -205 +205 @@
     Document doc = this.converter.getDOM(xml_in);
     
-    Element result = process(doc.getDocumentElement());
+    Node result = process(doc);
     return this.converter.getString(result);
   }
@@ -216 +216 @@
    * @see Element
    */
-  public Element process(Element message) {
-    
+  public Node process(Node message_node) {
+    
+      Element message = this.converter.nodeToElement(message_node);
+
     // check that its a correct message tag
     if (!message.getTagName().equals(GSXML.MESSAGE_ELEM)) {
@@ -737 +739 @@
     
     // process the message
-    Element info_response = comm.process(info_request);
+    Node info_response_node = comm.process(info_request);
+    Element info_response = converter.nodeToElement(info_response_node);
+
     if (info_response == null) {
       return false;