Changeset 18320 for gsdl/trunk/perllib/plugins/MP3Plugin.pm

Timestamp:

2009-01-06T19:03:58+13:00 (15 years ago)

Author:

ak19

Message:

Now plugins provide the option of base64 encoding or url encoding filenames that are to be renamed (when copied into the archives dir). Previously renamed files would always be url-encoded. URL-encoding is the default now for most plugins except MP3Plugin and OggVorbisPlugin, where the default is base64 encoding. Base64 encoding filenames upon renaming them was introduced so that more files that browsers try to open in external applications can open them, since url encoding does not seem to be implemented the same everywhere (for instance, windows media player is unable to handle url-encoded wmv filenames when such files are launched in it through the browser).

File:

• gsdl/trunk/perllib/plugins/MP3Plugin.pm (modified) (2 diffs)

gsdl/trunk/perllib/plugins/MP3Plugin.pm

@@ -60 +60 @@
     'desc' => "{MP3Plugin.metadata_fields}",
     'type' => "string",
-    'deft' => "Title,Artist,Genre" } ];
+    'deft' => "Title,Artist,Genre" },
+      { 'name' => "file_rename_method",
+    'desc' => "{BasePlugin.file_rename_method}",
+    'type' => "enum",
+    'deft' => &get_default_file_rename_method(), # by default rename imported files and assoc files using this encoding
+    'list' => $BasePlugin::file_rename_method_list,
+    'reqd' => "no"
+      } ];
 
 my $options = { 'name'     => "MP3Plugin",
@@ -83 +90 @@
 sub get_default_process_exp {
     return q^(?i)\.mp3$^;
+}
+
+# rename imported files and assoc files using base64 encoding by default
+# so that the urls generated will always work with media files even when
+# opened in external applications (when wmv file names contain spaces in
+# them and they get url-encoded, wmv player fails to open the doubly url-
+# encoded url reference to the url-encoded filename). 
+sub get_default_file_rename_method() {
+    return "base64";
 }