Changeset 32153 for main/trunk/gli/src/org/greenstone/gatherer/util/JarTools.java

Timestamp:

2018-02-26T19:57:21+13:00 (6 years ago)

Author:

ak19

Message:

2 Bugfixes and tidying up errorhandling in JarTools. 1. Dr Bainbridge fixed issue surrounding env.Path rather than env.PATH being used on Windows, while the empty env.PATH was being concatenated as a variable name by build.xml. This resulted in a cyclical reference, noticed when running the GLI Web Start Application (converted from GLI Applet). Fix is in build.xml. 2. My bugfix to WebGatherer.java, the new GLI Web Start Application. The collectionDir wasn't set correctly until the Gatherer object was instantiated, but the collect dir needed to be known by other code beforehand. So shifted the Gatherer object instantiation up a bit. 3. Can't yet reproduce the Exception seen twice before when running GLI Web Start application. The exception was thrown in ZipTools.java. Tested by rerunning the applet repeatedly, but it hasn't struck again yet. Perhaps it's been fixed now because of the other changes?

File:

• main/trunk/gli/src/org/greenstone/gatherer/util/JarTools.java (modified) (2 diffs)

main/trunk/gli/src/org/greenstone/gatherer/util/JarTools.java

@@ -133 +133 @@
     static public boolean isInJar(String filename) 
     {
+    InputStream fis = null;
     try {
-        InputStream fis = root_class.getResourceAsStream("/" + filename);           
-        fis.close();
+        fis = root_class.getResourceAsStream("/" + filename);
+        if(fis == null) {
+            System.err.println("@@@ JarTools.isInJar(): file inputstream for file /"+filename+" is still null. Not in jar file.");
+            return false;
+        }
     }
     catch (Exception exception) {
@@ -141 +145 @@
         return false;
     }
+    finally {
+        if(!SafeProcess.closeResource(fis)) {
+            System.err.println("@@@ JarTools.isInJar(): Couldn't close file inputstream");
+            return false;
+        }
+    }
 
     return true;