Changeset 34286 for main/trunk/gli/src/org/greenstone/gatherer/gui/FormatPane.java

Timestamp:

2020-07-23T21:07:18+12:00 (4 years ago)

Author:

ak19

Message:

Client-GLI was noticeably slow compared to GLI when swapping between format statements or when typing anything into a format statement. The cause was my own mistake from 9 years ago (commit revision 24424) when I didn't know that the CollectionManager.built() operation was an expensive remote call in the case of IsGsdlRemote. This function was being called to determine if the previewbutton should really be available (enabled or disabled) so that the user could not accidentally attempt to preview an unbuilt collection. However, I must not have realised back then that the previewbutton was being set this way at every character added into the Format statements editor, as well as when swapping between one format statement and another. As a result, all of such user action was being severely delayed when isGsdlRemote was true. Fixed this now by adding a function CollectionManager.previewAvailable() that returns the last known result of the built() call. Client-GLI's format pane is now thankfully so much faster, rather than a pain to use.

File:

• main/trunk/gli/src/org/greenstone/gatherer/gui/FormatPane.java (modified) (1 diff)

main/trunk/gli/src/org/greenstone/gatherer/gui/FormatPane.java

@@ -123 +123 @@
     // unbuilt (as could happen when someone clicks on a format statement before 
     // building the collection), then shouldn't enable previewing.
-    if(ready_to_preview && !Gatherer.c_man.built()) {
+    if(ready_to_preview && Gatherer.c_man.previewAvailable()) {
         ready_to_preview = false;
     }