Changeset 35286 for main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/UserQueryResult.java

Timestamp:

2021-08-12T17:53:14+12:00 (3 years ago)

Author:

anupama

Message:

First commit to do with supporting user groups of the form nz.ac.waikato.cs.pinky or katoa.maori.place.iwi.hapu.person, which need to get expanded out as nz, nz.ac, nz.ac.waikato, nz.ac.waikato.cs, nz.ac.waikato.cs.pinky (no duplicates). 1. Added a function that expands the existing groups and a new member variable to UserTermInfo that holds the expanded groups. 2. As also advised by Dr Bainbridge: refactored the existing UserTermInfo class to have getter and setter functions as needed and constructor so its member vars don't remain public as that also made it hard to track down in which classes/methods these member vars get (re)set. This commit should not have functionally altered the code: the origGroups (and not expandedGroups) is used everywhere still. In a subsequent commit will work out where the expandedGroups need to get used.

File:

• main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/UserQueryResult.java (modified) (1 diff)

main/trunk/greenstone3/src/java/org/greenstone/gsdl3/util/UserQueryResult.java

@@ -39 +39 @@
     public void addUserTerm(String username, String password, String groups, String accountstatus, String comment, String email)
     {
-        UserTermInfo ui = new UserTermInfo();
-        ui.username = username;
-        ui.password = password;
-        ui.groups = groups;
-        ui.accountstatus = accountstatus;
-        ui.comment = comment;
-        ui.email = email;
-        users.add(ui);
+        UserTermInfo ui = new UserTermInfo(username, password, groups,
+                           accountstatus, comment, email);      
+        users.add(ui);
     }