Changeset 6956

Timestamp:

2004-03-08T12:41:23+13:00 (20 years ago)

Author:

kjdon

Message:

removed some commented out stuff, added a new subroutine: format_metadata_for_sorting. all classifiers do this stuff, and they all do it a bit differently - put it here so they can share it and keep it consistent

File:

• trunk/gsdl/perllib/classify/BasClas.pm (modified) (4 diffs)

trunk/gsdl/perllib/classify/BasClas.pm

@@ -210 +210 @@
 
 
-#  sub print_general_usage {
-#      my ($plugin_name) = @_;
-#      print STDERR "
-#     -verbosity N    Controls the quantity of output.  
-#                     Defaults to verbosity of buildcol.pl, which is usually 2.
-
-#     (Most general classifier options are set internally by buildcol.)
-
-#  ";
-#  }
-
-# sub print_usage {
-#     print STDERR "
-# This classifier has no classifier-specific options
-# 
-# ";
-# }
-
 sub new {
     my $class = shift (@_);
@@ -247 +229 @@
 
     &gsprintf(STDERR, "\n{BasClas.bad_general_option}\n", $name);
-    # print STDERR "\nThe $name classifier uses an incorrect general option\n";
-    # print STDERR "(general options are those available to all classifiers).\n";
-    # print STDERR "Check your collect.cfg configuration file.\n";
     $self->print_txt_usage("");  # Use default resource bundle
     die "\n";
@@ -267 +246 @@
     my $outhandle = $self->{'outhandle'};
     &gsprintf($outhandle, "BasClass::classify {common.must_be_implemented}\n");
-    # print $outhandle "BasClas::classify function must be implemented in sub-class\n";
 }
 
@@ -275 +253 @@
     my $outhandle = $self->{'outhandle'};
     &gsprintf($outhandle, "BasClass::get_classify_info {common.must_be_implemented}\n");
-    # print $outhandle "BasClas::get_classify_info function must be implemented in sub-class\n";
-}
+}
+
+# all classifiers do something like this, but all slightly different
+# so put it here so they can all share it.
+sub format_metadata_for_sorting {
+
+    my $self = shift (@_);
+
+    my ($metaname, $metavalue, $doc_obj) = @_;
+    
+    if ($metaname eq "Language") {
+    $metavalue = $iso639::fromiso639{$metavalue};
+    return $metavalue;
+    } 
+    
+    my $lang = $doc_obj->get_metadata_element ($doc_obj->get_top_section(), 'Language');
+    $lang = 'en' unless defined $lang;
+    if ($lang eq 'en') {
+    if ($metaname eq "Creator") {
+        &sorttools::format_string_name_english (\$metavalue);
+    } else {
+        &sorttools::format_string_english (\$metavalue);
+    }
+    }
+    return $metavalue;
+}
+
 
 1;