Changeset 9851 for branches/ant-install-branch/gsdl3/src/java/org/greenstone/gsdl3/gs3build/metadata/METSFileSet.java

Timestamp:

2005-05-10T15:54:21+12:00 (19 years ago)

Author:

kjdon

Message:

some changes due to SQLConnection now closing the previous statement before executing a new one - this was a memory leak. but it means that if you want to iterate through an sql resultset and do other sql processing, you must use a different connection for the other sql requests

File:

• branches/ant-install-branch/gsdl3/src/java/org/greenstone/gsdl3/gs3build/metadata/METSFileSet.java (modified) (1 diff)

branches/ant-install-branch/gsdl3/src/java/org/greenstone/gsdl3/gs3build/metadata/METSFileSet.java

@@ -310 +310 @@
     
     // start going through the matching file groups
+    // clone the connection cos we are still usign the old result set
+    GS3SQLConnection cloned_connection = connection.cloneConnection();
     try {
         ResultSet resultSet = connection.getResultSet();
         resultSet.first();
         do {
-        METSFileGroup filegroup = METSFileGroup.readSQL(document, connection, resultSet);
+        METSFileGroup filegroup = METSFileGroup.readSQL(document, cloned_connection, resultSet);
         if (filegroup != null) {
             set.addGroup(filegroup);
         }
         } while (resultSet.next());
+
+        cloned_connection.close();
+        cloned_connection = null;
     }
     catch (SQLException sqlEx) {
         System.out.println(sqlEx);
+        sqlEx.printStackTrace();
         System.exit(1);
     }