Changeset 9851 for branches/ant-install-branch/gsdl3/src/java/org/greenstone/gsdl3/gs3build/metadata/METSStructureSet.java

Timestamp:

2005-05-10T15:54:21+12:00 (19 years ago)

Author:

kjdon

Message:

some changes due to SQLConnection now closing the previous statement before executing a new one - this was a memory leak. but it means that if you want to iterate through an sql resultset and do other sql processing, you must use a different connection for the other sql requests

File:

• branches/ant-install-branch/gsdl3/src/java/org/greenstone/gsdl3/gs3build/metadata/METSStructureSet.java (modified) (2 diffs)

branches/ant-install-branch/gsdl3/src/java/org/greenstone/gsdl3/gs3build/metadata/METSStructureSet.java

@@ -158 +158 @@
     select.setWhere(new GS3SQLWhere(whereItem));
     connection.execute(select.toString());
+    // clone the connection cos we are still usign the old result set
+    GS3SQLConnection cloned_connection = connection.cloneConnection();
 
     // start going through the matching metadata blocks
@@ -164 +166 @@
         resultSet.first();
         do {
-        METSStructure structure = METSStructure.readSQL(document, connection, resultSet);
+        METSStructure structure = METSStructure.readSQL(document, cloned_connection, resultSet);
         if (structure != null) {
             set.addStructure(structure);
         }
         } while (resultSet.next());
+        cloned_connection.close();
+        cloned_connection = null;
     }
     catch (SQLException sqlEx) {
         System.out.println(sqlEx);
+        sqlEx.printStackTrace();
         System.exit(1);
     }