Opened 7 years ago
Last modified 3 years ago
#935 new defect
Make perllib/IncrementalBuildUtils.pm reuse existing code
| Reported by: | ak19 | Owned by: | ak19 |
|---|---|---|---|
| Priority: | very high | Milestone: | 3.11 Release |
| Component: | Collection Building | Severity: | trivial |
| Keywords: | Cc: |
Description
Related to commits 31972 and 31973. Commit http://trac.greenstone.org/changeset/31972 contained a bug fix to perllib/IncrementalBuildUtils.pm by Dr Bainbridge.
IncrementalBuildUtils determines the PATH separator based on whether $GSDLOS contained the "win" substring denoting Windows. However, for the Mac OS, $GSDLOS has the value "darwin", which contains the "win" substring too. So Dr Bainbridge fixed the test to check for win as OS name prefix.
This part of the code will need to be reworked in future, such as to use util::envvar_prepend() and envvar_append() functions instead of concatenating something that may already be on the PATH. Also, check for any existing methods to test if OS is windows or not to put it all in one place.
Make the changes that reuse code BEFORE starting on GS3 release testing.
Ticket retargeted after milestone closed